[libvirt] [PATCH v2 0/3] misc virhostdevs cleanups

Michal Privoznik mprivozn at redhat.com
Wed Jul 31 12:53:58 UTC 2019


On 7/23/19 7:35 PM, Daniel Henrique Barboza wrote:
> changes in v2:
> - changed the parameter order in the function calls
> - gave up on moving virPCIDeviceSetX(pci, true) calls to
> virPCIDeviceReattach(). The attributes being set changes
> the behavior of virPCIDeviceReattach() in a more complex
> way than I expected. I still believe a simplification
> can be done there, but it became out of scope for a more
> simplistic cleanup such as this one.
> 
> These are cleanups that I made together with an attempt to
> enable parcial PCI Multifunction assignment with managed=true.
> 
> That work will be scrapped after discussions with Laine in
> [1], but these cleanups kind of make sense on their own, so
> here they are.
> 
> [1] https://www.redhat.com/archives/libvir-list/2019-July/msg01175.html
> 
> *** BLURB HERE ***
> 
> Daniel Henrique Barboza (3):
>    virhostdev: introduce virHostdevResetAllPCIDevices
>    virhostdev: remove virHostdevReattachPCIDevice
>    virhostdev: introduce virHostdevReattachAllPCIDevices
> 
>   src/util/virhostdev.c | 148 +++++++++++++++++-------------------------
>   src/util/virpci.c     |  14 ++++
>   2 files changed, 75 insertions(+), 87 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list