[libvirt] [PATCH 1/4] test_driver: introduce TEST_SET_PARAM macro

Peter Krempa pkrempa at redhat.com
Tue Jul 2 12:51:06 UTC 2019


On Tue, Jul 02, 2019 at 14:28:59 +0200, Ilias Stamatis wrote:
> This macro can be used by most or all of the DomainGetXXXParameters APIs.
> 
> Signed-off-by: Ilias Stamatis <stamatis.iliass at gmail.com>
> ---
>  src/test/test_driver.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> index 4b1f2724a0..29b388e2d3 100644
> --- a/src/test/test_driver.c
> +++ b/src/test/test_driver.c
> @@ -2844,6 +2844,13 @@ static char *testDomainGetXMLDesc(virDomainPtr domain, unsigned int flags)
>      return ret;
>  }
> 
> +
> +#define TEST_SET_PARAM(index, name, type, value) \

The macro name is too generic and this patch is not undefing it. You
should do it to prevent some accidental use in other parts of the code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190702/ffdb0f58/attachment-0001.sig>


More information about the libvir-list mailing list