[libvirt] [PATCH v2 1/9] vbox: Add various vir*Flags API

Peter Krempa pkrempa at redhat.com
Wed Jul 10 07:09:50 UTC 2019


On Tue, Jul 09, 2019 at 12:46:30 -0500, Eric Blake wrote:
> Even though we don't accept any flags, it is unfriendly to callers
> that use the modern API to have to fall back to the flag-free API.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/vbox/vbox_common.c | 24 ++++++++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)

[...]

> @@ -2775,6 +2788,11 @@ static int vboxDomainSetMemory(virDomainPtr dom, unsigned long memory)
>      return ret;
>  }
> 
> +static int vboxDomainSetMemory(virDomainPtr dom, unsigned long memory)
> +{
> +    return vboxDomainSetMemoryFlags(dom, memory, 0);

The old API was operating on a live VM only so this shim should imply
VIR_DOMAIN_AFFECT_LIVE.

> +}
> +
>  static int vboxDomainGetInfo(virDomainPtr dom, virDomainInfoPtr info)
>  {
>      vboxDriverPtr data = dom->conn->privateData;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190710/c164ca5c/attachment-0001.sig>


More information about the libvir-list mailing list