[libvirt] [PATCH] test_driver: consider flags in testDomainSetMemoryFlags

[Ilias Stamatis]

On Thu, Jul 11, 2019 at 4:03 PM Eric Blake <eblake at redhat.com> wrote:
>
> On 7/11/19 6:04 AM, Ilias Stamatis wrote:
> > Update the current or max memory, on the persistent or live definition
> > depending on the flags which are currently ignored.
> >
> > Signed-off-by: Ilias Stamatis <stamatis.iliass at gmail.com>
> > ---
> >  src/test/test_driver.c | 51 +++++++++++++++++++++++++++++++++++-------
> >  1 file changed, 43 insertions(+), 8 deletions(-)
> >
>
> Incomplete. You also need to fix what I missed in commit 667ac11e, in
> that testDomainSetMemory() should now forward to
> testDomainSetMemoryFlags(, VIR_DOMAIN_AFFECT_LIVE); and it would also be
> worth implementing testDomainSetMaxMemory() to forward to
> testDomainSetMemoryFlags(, VIR_DOMAIN_MEM_MAXIMUM).

Sure. But do you think they should be on the same patch?
Maybe in a subsequent patch on the same series?

>
> Oh, and thinking about it, maybe everywhere we have
> xxxDomainSetMaxMemory forwarding on, it seems odd that it is affecting
> VIR_DOMAIN_AFFECT_CURRENT instead of VIR_DOMAIN_AFFECT_LIVE; but then we
> have to start worrying about back-compat issues. :(

According to the documentation this is hypervisor-dependent so in the
case of the test driver I think it's fine to call it with
VIR_DOMAIN_AFFECT_LIVE.

However, changing it on other drivers raises compatibility issues as
you mentioned.

Ilias

>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org
>