[libvirt] [PATCH v4 3/8] qemu_capabilities: introduce QEMU_CAPS_QUERY_CPU_MODEL_BASELINE

Boris Fiuczynski fiuczy at linux.ibm.com
Wed Jul 24 16:18:53 UTC 2019


Reviewed-by: Boris Fiuczynski <fiuczy at linux.ibm.com>

On 7/17/19 4:03 PM, Collin Walling wrote:
> This capability enables CPU model baselining  between two CPU
> definitions via QMP.
> 
> Signed-off-by: Collin Walling <walling at linux.ibm.com>
> Reviewed-by: Daniel Henrique Barboza <danielh413 at gmail.com>
> ---
>   src/qemu/qemu_capabilities.c                     | 2 ++
>   src/qemu/qemu_capabilities.h                     | 1 +
>   tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 +
>   tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 +
>   tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 +
>   tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml  | 1 +
>   tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml  | 1 +
>   tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml  | 1 +
>   tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml  | 1 +
>   9 files changed, 10 insertions(+)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 6519246..b898113 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -536,6 +536,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
>   
>                 /* 335 */
>                 "bochs-display",
> +              "query-cpu-model-baseline",
>       );
>   
>   
> @@ -981,6 +982,7 @@ struct virQEMUCapsStringFlags virQEMUCapsCommands[] = {
>       { "blockdev-del", QEMU_CAPS_BLOCKDEV_DEL },
>       { "query-current-machine", QEMU_CAPS_QUERY_CURRENT_MACHINE },
>       { "block-dirty-bitmap-merge", QEMU_CAPS_BITMAP_MERGE },
> +    { "query-cpu-model-baseline", QEMU_CAPS_QUERY_CPU_MODEL_BASELINE },
>   };
>   
>   struct virQEMUCapsStringFlags virQEMUCapsMigration[] = {
> diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> index 3cb56e6..8dde759 100644
> --- a/src/qemu/qemu_capabilities.h
> +++ b/src/qemu/qemu_capabilities.h
> @@ -517,6 +517,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
>   
>       /* 335 */
>       QEMU_CAPS_DEVICE_BOCHS_DISPLAY, /* -device bochs-display */
> +    QEMU_CAPS_QUERY_CPU_MODEL_BASELINE, /* qmp query-cpu-model-baseline */
>   
>       QEMU_CAPS_LAST /* this must always be the last item */
>   } virQEMUCapsFlags;
> diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml
> index 21b918f..e6f7e28 100644
> --- a/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml
> +++ b/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml
> @@ -103,6 +103,7 @@
>     <flag name='egl-headless'/>
>     <flag name='zpci'/>
>     <flag name='iothread.poll-max-ns'/>
> +  <flag name='query-cpu-model-baseline'/>
>     <version>2010000</version>
>     <kvmVersion>0</kvmVersion>
>     <microcodeVersion>39100805</microcodeVersion>
> diff --git a/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml
> index 6cb997d..48d7742 100644
> --- a/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml
> +++ b/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml
> @@ -110,6 +110,7 @@
>     <flag name='egl-headless'/>
>     <flag name='zpci'/>
>     <flag name='iothread.poll-max-ns'/>
> +  <flag name='query-cpu-model-baseline'/>
>     <version>2011000</version>
>     <kvmVersion>0</kvmVersion>
>     <microcodeVersion>39100806</microcodeVersion>
> diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml
> index 2930381..381abd5 100644
> --- a/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml
> +++ b/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml
> @@ -121,6 +121,7 @@
>     <flag name='memory-backend-memfd.hugetlb'/>
>     <flag name='iothread.poll-max-ns'/>
>     <flag name='memory-backend-file.align'/>
> +  <flag name='query-cpu-model-baseline'/>
>     <version>2012000</version>
>     <kvmVersion>0</kvmVersion>
>     <microcodeVersion>39100807</microcodeVersion>
> diff --git a/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
> index 5a2b740..9516a3b 100644
> --- a/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
> +++ b/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
> @@ -92,6 +92,7 @@
>     <flag name='sdl-gl'/>
>     <flag name='vhost-vsock'/>
>     <flag name='zpci'/>
> +  <flag name='query-cpu-model-baseline'/>
>     <version>2007093</version>
>     <kvmVersion>0</kvmVersion>
>     <microcodeVersion>39100764</microcodeVersion>
> diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
> index 72ae100..cf8bbb2 100644
> --- a/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
> +++ b/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
> @@ -97,6 +97,7 @@
>     <flag name='vhost-vsock'/>
>     <flag name='zpci'/>
>     <flag name='iothread.poll-max-ns'/>
> +  <flag name='query-cpu-model-baseline'/>
>     <version>2009000</version>
>     <kvmVersion>0</kvmVersion>
>     <microcodeVersion>39100765</microcodeVersion>
> diff --git a/tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml b/tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml
> index d511377..40b4a2b 100644
> --- a/tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml
> +++ b/tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml
> @@ -123,6 +123,7 @@
>     <flag name='memory-backend-memfd.hugetlb'/>
>     <flag name='iothread.poll-max-ns'/>
>     <flag name='memory-backend-file.align'/>
> +  <flag name='query-cpu-model-baseline'/>
>     <version>3000000</version>
>     <kvmVersion>0</kvmVersion>
>     <microcodeVersion>39100757</microcodeVersion>
> diff --git a/tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml b/tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml
> index a1ac258..e72f447 100644
> --- a/tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml
> +++ b/tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml
> @@ -131,6 +131,7 @@
>     <flag name='query-current-machine'/>
>     <flag name='bitmap-merge'/>
>     <flag name='nbd-bitmap'/>
> +  <flag name='query-cpu-model-baseline'/>
>     <version>4000000</version>
>     <kvmVersion>0</kvmVersion>
>     <microcodeVersion>39100758</microcodeVersion>
> 


-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Matthias Hartmann
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294




More information about the libvir-list mailing list