[libvirt] [PATCH 4/4] qemu: Fix qemuProcessInitCpuAffinity()

Andrea Bolognani abologna at redhat.com
Mon Jun 3 12:15:01 UTC 2019


On Fri, 2019-05-31 at 17:22 +0200, Andrea Bolognani wrote:
> Commit f136b83139c6 made some changes in the way we set CPU
> affinity for QEMU processes, and while doing so unfortunately
> also introduced a logic bug in that it tried to use a NUMA node
> map where a CPU map was expected.

Correction: the logic bug was present even in the original
implementation of the feature, introduced back in 2012 (!) with
commit 0f8e7ae33ace; setting the CPU affinity earlier in the guest
startup process, as we're doing since a few releases back, has
probably just made the mistake easier to spot.

Or maybe nobody was using it on POWER 8 and that's why we never
realized something was wrong :)

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list