[libvirt] [PATCH 09/13] qemu: snapshot: Move all cleanup of snapshot disk data to qemuDomainSnapshotDiskDataFree

Ján Tomko jtomko at redhat.com
Sat Jun 8 14:16:06 UTC 2019


On Wed, Jun 05, 2019 at 05:28:31PM +0200, Peter Krempa wrote:
>qemuDomainSnapshotDiskDataFree also removes the resources associated
>with the disk data. Move the unlinking of the just-created file so that
>we can unify the cleanup paths.
>

Pre-exisiting since commit cbb4d229, but touching the disk state from a
*Free function feels wrong.

Can you rename it first?

>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_driver.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190608/192d523a/attachment-0001.sig>


More information about the libvir-list mailing list