[libvirt] [PATCH] test_driver: implement virConnectGetLibVersion

[Ilias Stamatis]

On Mon, Jun 10, 2019 at 3:35 PM Erik Skultety <eskultet at redhat.com> wrote:
>
> On Mon, Jun 10, 2019 at 02:38:15PM +0200, Ilias Stamatis wrote:
> > Signed-off-by: Ilias Stamatis <stamatis.iliass at gmail.com>
> > ---
> >  src/test/test_driver.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> > index 1aa79ce898..dc267b6ecd 100644
> > --- a/src/test/test_driver.c
> > +++ b/src/test/test_driver.c
> > @@ -1453,6 +1453,14 @@ static char *testConnectGetHostname(virConnectPtr conn ATTRIBUTE_UNUSED)
> >  }
> >
> >
> > +static int testConnectGetLibVersion(virConnectPtr conn ATTRIBUTE_UNUSED,
> > +                                    unsigned long *libVer)
> > +{
> > +    *libVer = LIBVIR_VERSION_NUMBER;
> > +    return 0;
> > +}
>
> Test driver is implemented entirely on the client side, so implementing this
> API is unnecessary, since the public API returns the value in the client
> library if a specific driver doesn't implement it. If test driver was
> implemented within the daemon, then it could be different, but in this case it
> cannot, so NACK from my POV.
>
> Regards,
> Erik

That makes sense. So let's not touch this then.

Ilias