[libvirt] [PATCH v4 10/25] virfile: Make virFileGetXAttr report errors

Daniel P. Berrangé berrange at redhat.com
Mon Jun 17 13:21:13 UTC 2019


On Thu, Apr 25, 2019 at 10:19:46AM +0200, Michal Privoznik wrote:
> The way that security drivers use XATTR is kind of verbose. If
> error reporting was left for caller then the caller would end up
> even more verbose.
> 
> There are two places where we do not want to report error if
> virFileGetXAttr fails. Therefore virFileGetXAttrQuiet is
> introduced as an alternative that doesn't report errors.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> Reviewed-by: Cole Robinson <crobinso at redhat.com>
> ---
>  src/libvirt_private.syms     |  1 +
>  src/security/security_util.c |  4 ++--
>  src/util/virfile.c           | 42 ++++++++++++++++++++++++++++++------
>  src/util/virfile.h           |  5 +++++
>  tests/qemusecuritymock.c     |  6 +++---
>  5 files changed, 46 insertions(+), 12 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list