[libvirt] [PATCH] remote: use VIR_DRV_OPEN_REMOTE_USER in ssh transport checks

Michal Privoznik mprivozn at redhat.com
Wed Jun 19 11:58:22 UTC 2019


On 6/19/19 12:43 PM, Daniel P. Berrangé wrote:
> We currently refuse to connect to remote libvirtd over SSH if we see the
> path ends in /session. Earlier on though we checked for /session and set
> the VIR_DRV_OPEN_REMOTE_USER flag. There is one subtle distinction
> though with the test driver. All test URIs are marked with this flag,
> regardless of whether the URI indicates a local or remote connection.
> Previously a local connection to the test driver would have used the
> unprivileged libvirtd while a remote connection would have tried the
> privileged libvirtd. With this we are consistent and use the
> unprivileged for both local & remote, if the current user is non-root.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>   src/remote/remote_driver.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list