[libvirt] [PATCH] remote: delete the avahi mDNS support

[Ján Tomko]

On Wed, Jun 19, 2019 at 05:09:26PM +0100, Daniel P. Berrangé wrote:
>Libvirtd has long had integration with avahi for advertising libvirtd
>using mDNS when TCP/TLS listening is enabled. For a long time the
>virt-manager application had support for auto-detecting libvirtds
>on the local network using mDNS, but this was removed last year
>
>  commit fc8f8d5d7e3ba80a0771df19cf20e84a05ed2422
>  Author: Cole Robinson <crobinso at redhat.com>
>  Date:   Sat Oct 6 20:55:31 2018 -0400
>
>    connect: Drop avahi support
>
>    Libvirtd can advertise itself over avahi. The feature is disabled by
>    default though and in practice I hear of no one actually using it
>    and frankly I don't think it's all that useful
>
>    The 'Open Connection' wizard has a disproportionate amount of code
>    devoted to this feature, but I don't think it's useful or worth
>    maintaining, so let's drop it
>
>I've never heard of any other applications having support for using
>mDNS to detect libvirtd instances. Though it is theoretically possible
>something exists out there, it is clearly going to be a niche use case
>in the virt ecosystem as a whole.
>
>By removing avahi integration we can cut down the dependancy chain for

dependency

>the basic libvirtd install and reduce our code maint burden.
>
>Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>---
> cfg.mk                                        |   3 -
> configure.ac                                  |   3 -

[...]

> .../output-data-initial-nomdns.json           |  72 --
> .../virnetdaemondata/output-data-initial.json |   1 -
> tests/virnetdaemontest.c                      |  17 +-
> 34 files changed, 16 insertions(+), 1211 deletions(-)
> delete mode 100644 m4/virt-avahi.m4
> delete mode 100644 src/rpc/virnetservermdns.c
> delete mode 100644 src/rpc/virnetservermdns.h
> rename tests/virnetdaemondata/{input-data-admin-nomdns.json => input-data-admin.json} (100%)
> delete mode 100644 tests/virnetdaemondata/input-data-initial-nomdns.json
> rename tests/virnetdaemondata/{output-data-admin-nomdns.json => output-data-admin.json} (100%)
> delete mode 100644 tests/virnetdaemondata/output-data-initial-nomdns.json
>

diff --git a/src/libvirt_remote.syms b/src/libvirt_remote.syms
index eb7651a957..b63eac123f 100644
--- a/src/libvirt_remote.syms
+++ b/src/libvirt_remote.syms
@@ -133,7 +133,6 @@ virNetServerSetClientAuthenticated;
 virNetServerSetClientLimits;
 virNetServerSetThreadPoolParameters;
 virNetServerSetTLSContext;
-virNetServerStart;
 virNetServerUpdateServices;

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190619/bce8277f/attachment-0001.sig>