[libvirt] [PATCHv2 9/9] qemu: Move qemuParseKeywords(Free) to the monitor code
Peter Krempa
pkrempa at redhat.com
Thu Jun 20 10:14:04 UTC 2019
On Mon, Jun 17, 2019 at 17:17:35 +0200, Andrea Bolognani wrote:
> On Mon, 2019-06-17 at 14:55 +0200, Peter Krempa wrote:
> > The only user is now in qemu_monitor_json.c to re-parse the command line
> > format into keyvalue pairs for use in QMP command construction.
> >
> > Move and rename the functions.
> >
> > Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> > ---
> > po/POTFILES | 1 -
> > src/qemu/Makefile.inc.am | 2 -
> > src/qemu/qemu_monitor_json.c | 124 +++++++++++++++++++++++++++-
> > src/qemu/qemu_parse_command.c | 149 ----------------------------------
> > src/qemu/qemu_parse_command.h | 37 ---------
> > 5 files changed, 120 insertions(+), 193 deletions(-)
> > delete mode 100644 src/qemu/qemu_parse_command.c
> > delete mode 100644 src/qemu/qemu_parse_command.h
>
> Reviewed-by: Andrea Bolognani <abologna at redhat.com>
>
> As mentioned with the RFC, please don't push this right away but
> wait a week or so to give everyone a chance to voice their opinion
> about this removal.
I think everybody had plenty time to respond by now. I'll be pushing
this series shortly.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190620/bcf818b8/attachment-0001.sig>
More information about the libvir-list
mailing list