[libvirt] [PATCH 1/2] qemu: driver: Fix off-by-one in qemuDomainSnapshotDiskDataCollect

Ján Tomko jtomko at redhat.com
Thu Jun 20 13:56:02 UTC 2019


On Thu, Jun 20, 2019 at 03:47:56PM +0200, Peter Krempa wrote:
>Commit f34397e51c17 introduced a crash-inducing problem when collecting
>disk snapshot data, where the array would be filled starting from the
>second element.
>
>The code then dereferenced the first one.
>

How did this get past review?

>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190620/ce62c1d2/attachment-0001.sig>


More information about the libvir-list mailing list