[libvirt] [PATCH 02/10] qemu: hotplug: Handle copy-on-read filter separate from rest of backing chain

Ján Tomko jtomko at redhat.com
Tue Jun 25 14:27:10 UTC 2019


On Mon, Jun 24, 2019 at 05:38:47PM +0200, Peter Krempa wrote:
>We use only one copy-on-read filter per disk, so we should handle it
>separately from the chain.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_hotplug.c | 46 ++++++++++++++++++++++-------------------
> 1 file changed, 25 insertions(+), 21 deletions(-)
>
>@@ -812,6 +791,8 @@ qemuDomainAttachDiskGeneric(virQEMUDriverPtr driver,
>     qemuHotplugDiskSourceDataPtr diskdata = NULL;
>     char *devstr = NULL;
>     VIR_AUTOUNREF(virQEMUDriverConfigPtr) cfg = virQEMUDriverGetConfig(driver);
>+    VIR_AUTOPTR(virJSONValue) corProps = NULL;
>+    VIR_AUTOFREE(char *)corAlias = NULL;

Space.

>
>     if (qemuDomainStorageSourceChainAccessAllow(driver, vm, disk->src) < 0)
>         goto cleanup;

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190625/f71da05e/attachment-0001.sig>


More information about the libvir-list mailing list