[libvirt] [PATCH 0/4] Remove VIR_ERR_DEPRECATED & associated pieces

Ján Tomko jtomko at redhat.com
Wed Jun 26 17:25:16 UTC 2019


On Wed, Jun 26, 2019 at 04:54:39PM +0100, Daniel P. Berrangé wrote:
>A deprecation is inherantly a warning, not an error, so adding an error
>with this name makes no conceptual sense.
>
>Features in drivers may come & go at any time and we've always use the
>VIR_ERR_NO_SUPPORT to indicate when a hypervisor driver does not support
>a particular API.
>
>Daniel P. Berrangé (4):
>  qemu: delete methods which are no longer supported
>  Revert "error: Add VIR_ERR_DEPRECATED error code"
>  Revert "docs: css: Add style for <span class='deprecated'> ..."
>  Revert "docs: hvsupport: Add support for deprecating hypervisor
>    implementations"
>
> docs/hvsupport.pl           | 44 ++++++++++++-------------------------
> docs/libvirt.css            | 10 ---------
> include/libvirt/virterror.h |  1 -
> src/qemu/qemu_driver.c      | 31 --------------------------
> src/util/virerror.c         |  4 ----
> 5 files changed, 14 insertions(+), 76 deletions(-)
>

Missing a revert of:
commit 3026f6d9d986ad63c4b4a1c57589e6d05b71bd70
    news: Mention VIR_ERR_DEPRECATED in improvements

I wish it would have been the first news revert in this release cycle.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190626/1e27ffb0/attachment-0001.sig>


More information about the libvir-list mailing list