[libvirt] [PATCH 3/4] Revert "docs: css: Add style for <span class='deprecated'> ..."

Peter Krempa pkrempa at redhat.com
Thu Jun 27 06:09:03 UTC 2019


On Wed, Jun 26, 2019 at 19:47:07 +0200, Ján Tomko wrote:
> On Wed, Jun 26, 2019 at 04:54:42PM +0100, Daniel P. Berrangé wrote:
> > This reverts commit 71626402f481ed47ff67dafa8521b01a42625707.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> > docs/libvirt.css | 6 ------
> > 1 file changed, 6 deletions(-)
> > 
> > diff --git a/docs/libvirt.css b/docs/libvirt.css
> > index 6639b1df64..54d015db98 100644
> > --- a/docs/libvirt.css
> > +++ b/docs/libvirt.css
> > @@ -274,12 +274,6 @@ span.since {
> >     font-weight: bold;
> > }
> > 
> > -span.deprecated {
> > -    color: darkred;
> > -    font-style: italic;
> > -    font-weight: bold;
> > -}
> > -
> > img.diagram {
> >     background: rgb(230,230,230);
> >     border: 2px dotted rgb(178,178,178);
> 
> Also, this is used by docs/drvqemu.html.in, since:
> commit d127bc3ce6eaf4b48dd09305368ac6a727d5aecf
>    docs: drvqemu: Add note about deprecation of domxml-from-native
> 
> where we can either:
> a) drop the reference to the removed class
> b) drop the reference to the removed command

I don't think we should cover up that we deleted old functionality.

I don't care that much about the error code being reverted, but I think
covering up that we've deleted this is a wrong idea.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190627/5e4d7f42/attachment-0001.sig>


More information about the libvir-list mailing list