[libvirt] [PATCH v2 4/4] Revert "error: Add VIR_ERR_DEPRECATED error code"

Peter Krempa pkrempa at redhat.com
Thu Jun 27 10:46:26 UTC 2019


On Thu, Jun 27, 2019 at 10:06:05 +0100, Daniel Berrange wrote:
> This reverts commit 226094fbc483128c8888f4171c353aed738b8346.
> 
> A deprecation is a warning to something that use of a feature is
> being discouraged. By definition it is not an error condition to
> continue to use a deprecated feature.
> 
> A VIR_ERR_DEPRECATED constant thus makes no conceptual sense. For
> features which are entirely absent we already document that the
> VIR_ERR_NO_SUPPORT code will be used. There is no need to distinguish
> between a feature which never existed and a feature which previously
> existed and was since removed.
> 
> Reviewed-by: Ján Tomko <jtomko at redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190627/b0d86293/attachment-0001.sig>


More information about the libvir-list mailing list