[libvirt] [PATCH v6 2/9] Revert "snapshot: Add virDomainSnapshotObjListFormat"

Ján Tomko jtomko at redhat.com
Tue Mar 26 16:49:22 UTC 2019


On Tue, Mar 26, 2019 at 01:13:46AM -0500, Eric Blake wrote:
>This reverts commit 86c0ed6f70268dfa7c3bba95a0ba96fcfe2ab039, and
>subsequent refactorings of the function into new files.  There are no
>callers of this function - I had originally proposed it for
>implementing a new bulk snapshot API, but that proved to be too
>invasive given RPC limits. I also tried using it for streamlining how
>the qemu driver stores snapshot state across libvirtd restarts
>internally, but in the end, the risks of a new internal format
>outweighed the benefits of one file per snapshot.
>
>Signed-off-by: Eric Blake <eblake at redhat.com>
>---
> src/conf/snapshot_conf.h            |  7 ----
> src/conf/virdomainsnapshotobjlist.h |  7 ----
> src/conf/snapshot_conf.c            |  2 +-
> src/conf/virdomainsnapshotobjlist.c | 61 -----------------------------
> src/libvirt_private.syms            |  1 -
> 5 files changed, 1 insertion(+), 77 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190326/f13aa65f/attachment-0001.sig>


More information about the libvir-list mailing list