[libvirt] [PATCH 1/3] tests: Rename some qemuxml2xml output files for clarity

[Ján Tomko]

On Thu, Feb 28, 2019 at 05:38:45PM +0100, Andrea Bolognani wrote:
>disk-mirror-old has different output file for the active and
>inactive parts, which should be named accordingly; on the other
>hand, both output files for disk-backing-chains-noindex are
>identical, so it makes sense to only keep around one and remove
>the (in-)active suffix.
>
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
> .../disk-backing-chains-noindex-inactive.xml  | 156 ------------------
> ...ve.xml => disk-backing-chains-noindex.xml} |   0
> ...ror-old.xml => disk-mirror-old-active.xml} |   0
> 3 files changed, 156 deletions(-)
> delete mode 100644 tests/qemuxml2xmloutdata/disk-backing-chains-noindex-inactive.xml
> rename tests/qemuxml2xmloutdata/{disk-backing-chains-noindex-active.xml => disk-backing-chains-noindex.xml} (100%)
> rename tests/qemuxml2xmloutdata/{disk-mirror-old.xml => disk-mirror-old-active.xml} (100%)

You renamed the test files without altering qemuxml2xmltest.c and the test
still passes. That's disturbing.

But the change makes sense.
Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190301/007accb3/attachment-0001.sig>