[libvirt] [jenkins-ci PATCH v6 1/4] mappings: extend mapping to allow per-arch entries

[Andrea Bolognani]

On Thu, 2019-02-28 at 15:53 +0000, Daniel P. Berrangé wrote:
> For example to prevent Xen being installed on any s390x
> 
>   xen:
>     deb: libxen-dev
>     Fedora: xen-devel
>     s390x-default:
> 
> Or the inverse to only install Xen on x86_64 on Debian, but allow
> it on all archs on Fedora
> 
>   xen:
>     Fedora: xen-devel
>     x86_64-deb: libxen-dev

It's not necessary to repeat the examples verbatim in the commit
message, they're already in the diff.

[...]
> The ansible playbook is not actually implementing support for

s/ansible/Ansible/

[...]
> +++ b/guests/playbooks/update/tasks/packages.yml
> @@ -52,6 +52,38 @@
>    when:
>      - mappings[item][os_name + os_version] is defined
>  
> +- name: '{{ project }}: Look up mappings (default with arch)'

In the documentation you have used "arch with default" rather
than "default with arch", so you might want to keep these messages
consistent.

[...]
> @@ -27,6 +43,21 @@
>  #
>  # will result in the 'ccache' package being installed everywhere except
>  # for CentOS, where nothing will be installed.
> +#
> +# For example to prevent Xen being installed on any s390x

s/any //

> +#
> +#  xen:
> +#    deb: libxen-dev
> +#    Fedora: xen-devel
> +#    s390x-default:
> +#
> +# Or the inverse to only install Xen on x86_64 only on debian
> +# based distros or Fedora

s/debian based/Debian-based/


With the above addressed,

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization