[libvirt] [PATCH 3/5] util: Rename virFileMatchesNameSuffix() to virStringMatchesNameSuffix()

Peter Krempa pkrempa at redhat.com
Thu Mar 7 07:58:10 UTC 2019


On Wed, Mar 06, 2019 at 17:54:02 +0100, Andrea Bolognani wrote:
> Despite its name, this is really just a general-purpose string
> manipulation function, so it should be moved to the virstring
> module and renamed accordingly.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  src/conf/virsecretobj.c  |  2 +-
>  src/conf/virstorageobj.c |  2 +-
>  src/libvirt_private.syms |  2 +-
>  src/util/virfile.c       | 17 -----------------
>  src/util/virfile.h       |  4 ----
>  src/util/virstring.c     | 17 +++++++++++++++++
>  src/util/virstring.h     |  3 +++
>  7 files changed, 23 insertions(+), 24 deletions(-)

ACK.

Although you could also fix the return value type when at it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190307/4e9ba1c4/attachment-0001.sig>


More information about the libvir-list mailing list