[libvirt] [PATCH 1/1] tests: fix valgrind.supp path in Makefile

Michal Privoznik mprivozn at redhat.com
Mon Mar 11 14:12:42 UTC 2019


On 3/11/19 2:19 PM, Shotaro Gotanda wrote:
> At the current time, several test case result in failure
> in "make -C tests valgrind". This commit fix the problem.
> 
> Signed-off-by: Shotaro Gotanda <g.sho1500 at gmail.com>
> ---
>   tests/Makefile.am | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 72f0420bab..97e61d9088 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -495,7 +495,7 @@ TESTS_ENVIRONMENT = \
>   
>   VALGRIND = valgrind --quiet --leak-check=full --trace-children=yes \
>   	--trace-children-skip="*/tools/virsh","*/tests/commandhelper" \
> -	--suppressions=$(srcdir)/.valgrind.supp
> +	--suppressions=$(abspath $(srcdir))/.valgrind.supp

We have abs_srcdir variable. I'm switching the code over to use that, 
fixing the commit message a bit, ACKing and pushing.

Congratulations on your first libvirt contribution!

Michal




More information about the libvir-list mailing list