[libvirt] [jenkins-ci PATCH 1/3] lcitool: remove Error class for exception handling

[Andrea Bolognani]

On Tue, 2019-03-12 at 10:49 +0000, Daniel P. Berrangé wrote:
[...]
> @@ -583,18 +577,18 @@ class Application:
>          os_full = os_name + os_version
>  
>          if package_format not in ["deb", "rpm"]:
> -            raise Error("Host {} doesn't support Dockerfiles".format(host))
> +            raise Exception("Host {} doesn't support Dockerfiles".format(host))
>          if args.cross_arch:
>              if os_name != "Debian":
> -                raise Error("Cannot cross compile on {}".format(os_name))
> +                raise Exception("Cannot cross compile on {}".format(os_name))
>              if args.cross_arch == self._native_arch:
> -                raise Error("Cross arch {} should differ from native {}".
> +                raise Exception("Cross arch {} should differ from native {}".
>                              format(args.cross_arch, self._native_arch))

This is not indented correctly.

[...]
> @@ -620,8 +614,8 @@ class Application:
>                      if key in mappings[package]:
>                          cross_policy = mappings[package][key]
>                  if cross_policy not in ["native", "foreign", "skip"]:
> -                    raise Error("Unexpected cross arch policy {} for {}",
> -                                cross_policy, package)
> +                    raise Exception("Unexpected cross arch policy {} for {}",
> +                                    cross_policy, package)

There should have been a call to format() here! Aren't dynamic
programming languages fun? --"


If you fix the two issues mentioned above, possibly in a separate
trivial patch right before this one,

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization