[libvirt] [PATCH] spec: Only call ldconfig on RHEL7

Andrea Bolognani abologna at redhat.com
Tue Mar 19 08:13:20 UTC 2019


On Mon, 2019-03-18 at 15:35 -0400, Cole Robinson wrote:
> Since Fedora 28 (our minimum supported build), ldconfig is called
> automatically for us:
> 
> https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
> 
> These changes appear to be implemented for rhel > 7 as well, so only
> run ldconfig on rhel7

s/rhel/RHEL/g

Also we are allowed to say "RHEL 8" now ;)

[...]
> +++ b/libvirt.spec.in
> @@ -1477,12 +1477,16 @@ exit 0
>  
>  %post client
>  
> +%if 0%{?rhel} == 7
>  /sbin/ldconfig
> +%endif
>  %systemd_post libvirt-guests.service
>  
>  %postun client
>  
> +%if 0%{?rhel} == 7
>  /sbin/ldconfig
> +%endif
>  %systemd_postun libvirt-guests.service
>  
>  %triggerun client -- libvirt < 0.9.4

IIUC ldconfig should be called after installing the libraries, but
here we're calling it in %post(un) for the client subpackage which
I believe is incorrect. We should fix that too.

Your changes look good otherwise, and it doesn't really matter in
which order the changes are applied, so

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list