[libvirt] [PATCH 07/21] tests: qemuxml2argv: handle migrate* with varargs

Andrea Bolognani abologna at redhat.com
Tue Mar 19 13:08:50 UTC 2019


On Thu, 2019-03-14 at 10:44 -0400, Cole Robinson wrote:
[...]
> -    DO_TEST_FULL("restore-v2", "exec:cat", 7, 0, 0,
> +    DO_TEST_FULL("restore-v2", 0, 0,
> +                 ARG_MIGRATE_FROM, "exec:cat", ARG_MIGRATE_FD, 7,
>                   ARG_QEMU_CAPS, NONE);
> -    DO_TEST_FULL("restore-v2-fd", "stdio", 7, 0, 0,
> +    DO_TEST_FULL("restore-v2-fd", 0, 0,
> +                 ARG_MIGRATE_FROM, "stdio", ARG_MIGRATE_FD, 7,
>                   ARG_QEMU_CAPS, NONE);
> -    DO_TEST_FULL("restore-v2-fd", "fd:7", 7, 0, 0,
> +    DO_TEST_FULL("restore-v2-fd", 0, 0,
> +                 ARG_MIGRATE_FROM, "fd:7", ARG_MIGRATE_FD, 7,
>                   ARG_QEMU_CAPS, NONE);

I'd put ARG_MIGRATE_FROM and ARG_MIGRATE_FD on separate lines here.

Either way,

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list