[libvirt] [PATCH 03/21] qemu_hotplug: remove unnecessary check for valid PCI address

[Peter Krempa]

On Thu, Mar 21, 2019 at 18:28:43 -0400, Laine Stump wrote:
> When support for hotplug/unplug of SCSI controllers was added way back
> in December 2009 (commit da9d937b), unplug was handled by calling the
> now-extinct function qemuMonitorRemovePCIDevice(), which required a
> PCI address as an argument. At the same time, the idea of every device
> in the config having a PCI address apparentlty was not yet fully
> implemented, because the author of the patch including a check for a
> valid PCI address in the device object.
> 
> These days, all PCI devices are guaranteed to have a valid PCI
> address. But more important than that, we no longer detach devices by
> PCI address, but instead use qemuDomainDeleteDevice(), which
> identifies the device by its alias. So checking for a valid PCI
> address is just pointless extra code that obscures the high level of
> similarity between all the individual qemuDomainDetach*Device()
> functions.
> 
> Signed-off-by: Laine Stump <laine at laine.org>
> ---
>  src/qemu/qemu_hotplug.c | 16 ----------------
>  1 file changed, 16 deletions(-)

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190322/57c8f4f0/attachment-0001.sig>