[libvirt] [PATCH v3 18/36] network: convert networkAllocateActualDevice to virNetworkPortDef

[Laine Stump]

On 3/19/19 8:46 AM, Daniel P. Berrangé wrote:
> Convert the virDomainNetDef object into a virNetworkPortDef object
> at the start of networkAllocateActualDevice. This largely decouples
> the method impl from the domain object type.
>
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>   src/network/bridge_driver.c | 222 +++++++++++++++---------------------
>   1 file changed, 91 insertions(+), 131 deletions(-)
>
> diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
> index 9eda1c62b0..cd53e124c2 100644
> --- a/src/network/bridge_driver.c
> +++ b/src/network/bridge_driver.c
> @@ -67,6 +67,7 @@
>   #include "network_event.h"
>   #include "virhook.h"
>   #include "virjson.h"
> +#include "conf/virnetworkportdef.h"


Shouldn't need the "conf/" there.


I didn't see any other problem.


Reviewed-by: Laine Stump <laine at laine.org>