[libvirt] [PATCH] qemufirmwaretest: Produce better message on error

Andrea Bolognani abologna at redhat.com
Tue Mar 26 08:41:29 UTC 2019


On Tue, 2019-03-26 at 09:02 +0100, Michal Privoznik wrote:
> If qemuFirmwareFetchConfigs() returned more or less paths than

https://66.media.tumblr.com/c9eb5611a9f9c6a5cb7be6d5365afdf9/tumblr_ouaw1xYO8u1ruwssto2_500.gif

> expected all that we see is the following error message:
> 
>   Expected 5 paths, got 7
> 
> While it is technically correct (the best kind of correct), we
> can do better:
> 
>   Unexpected path (i=0). Expected /some/path got /some/other/path
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tests/qemufirmwaretest.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)

Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list