[libvirt] [PATCH] qemu_capabilities: Pass pointer to va_list in virQEMUCapsSetVAList

[Daniel P. Berrangé]

On Wed, Mar 27, 2019 at 05:13:59PM +0100, Michal Privoznik wrote:
> On 3/27/19 4:49 PM, Michal Privoznik wrote:
> 
> > 
> > Okay, thanks for detailed explanation. I'll probably go with what Dan
> > sugested and make virQEMUCapsSetVAList inline then. It looks safer and
> > more portable.
> 
> Actually, that does not work. Because even if I mark the function 'inline'
> gcc still produces assembly code that calls the function. So I've tried to
> come around that using attribute always_inline. But for some reason it is
> still not working.
> 
> I guess at this point, it's the best to just drop the virQEMUCapsSetVAList()
> completely.

Yeah I should have been clearer. WHen I said "inline" virQEMUCapsSetVAList,
I really did mean drop this function entirely & copy its 2 lines of code
into the caller.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|