[libvirt] [jenkins-ci PATCH v2] lcitool: check for virt-install / ansible-playbook in $PATH

[Daniel P. Berrangé]

On Fri, May 03, 2019 at 05:37:58PM +0200, Andrea Bolognani wrote:
> On Fri, 2019-05-03 at 11:02 +0100, Daniel P. Berrangé wrote:
> > This improves error reporting:
> > 
> >   $ ./lcitool install libvirt-fedora-29
> >   ./lcitool: Failed to install 'libvirt-fedora-29': [Errno 2] No such file or directory
> > 
> > To
> > 
> >   $ ./lcitool install libvirt-fedora-29
> >   ./lcitool: Cannot find virt-install in $PATH
> 
> Much nicer indeed!
> 
> > @@ -461,8 +462,12 @@ class Application:
> >              "git_branch": git_branch,
> >          })
> >  
> > +        ap_path = distutils.spawn.find_executable("ansible-playbook")
> 
> Please call this 'ansible_playbook' instead of 'ap_path'...
> 
> > @@ -534,8 +539,12 @@ class Application:
> >              # a kernel argument
> >              extra_arg = "console=ttyS0 ks=file:/{}".format(install_config)
> >  
> > +            vi_path = distutils.spawn.find_executable("virt-install")
> 
> ... and same here.

I'll call this one  "virt_install" rather than "ansible_playbook" ;-P


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|