[libvirt] [PATCH 2/2] test_driver: Don't report VIR_DOMAIN_DISK_ERROR_NONE

Michal Privoznik mprivozn at redhat.com
Tue May 14 15:12:42 UTC 2019


In my review of 89320788ac4 I've simplified assigning disk errors
too much as the code I've changed it to will set
VIR_DOMAIN_DISK_ERROR_NONE. This is in contradiction with our
documentation which specifies that disks with no errors are not
reported.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/test/test_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index cfa739ecca..ad89663de2 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -3067,7 +3067,7 @@ static int testDomainGetDiskErrors(virDomainPtr dom,
         for (i = 0; i < MIN(vm->def->ndisks, maxerrors); i++) {
             if (VIR_STRDUP(errors[i].disk, vm->def->disks[i]->dst) < 0)
                 goto cleanup;
-            errors[i].error = i % VIR_DOMAIN_DISK_ERROR_LAST;
+            errors[i].error = (i % (VIR_DOMAIN_DISK_ERROR_LAST - 1)) + 1;
         }
         ret = i;
     } else {
-- 
2.21.0




More information about the libvir-list mailing list