[libvirt] [PATCH 03/12] qemu: driver: Don't try to update blockjob status in qemuDomainGetBlockJobInfo
Peter Krempa
pkrempa at redhat.com
Fri May 17 11:19:49 UTC 2019
All blockjobs get their status updated by events from qemu, so this code
no longer makes sense.
Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
src/qemu/qemu_driver.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 0a425b82e5..33ccb4dfba 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -17442,20 +17442,6 @@ qemuDomainGetBlockJobInfo(virDomainPtr dom,
goto endjob;
}
- /* Snoop block copy operations, so future cancel operations can
- * avoid checking if pivot is safe. Save the change to XML, but
- * we can ignore failure because it is only an optimization. We
- * hold the vm lock, so modifying the in-memory representation is
- * safe, even if we are a query rather than a modify job. */
- if (disk->mirror &&
- rawInfo.ready != 0 &&
- info->cur == info->end && !disk->mirrorState) {
- virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
-
- disk->mirrorState = VIR_DOMAIN_DISK_MIRROR_STATE_READY;
- ignore_value(virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps));
- virObjectUnref(cfg);
- }
endjob:
qemuDomainObjEndJob(driver, vm);
--
2.21.0
More information about the libvir-list
mailing list