[libvirt] [PATCH 08/10] conf: turn virDomainMemtuneFormat void

Peter Krempa pkrempa at redhat.com
Tue Nov 12 07:27:45 UTC 2019


Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/conf/domain_conf.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0e774889a2..81ab5eb138 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -27953,12 +27953,11 @@ virDomainIOMMUDefFormat(virBufferPtr buf,
 }


-static int
+static void
 virDomainMemtuneFormat(virBufferPtr buf,
                        const virDomainMemtune *mem)
 {
     g_auto(virBuffer) childBuf = VIR_BUFFER_INITIALIZER;
-    int ret = -1;

     virBufferSetChildIndent(&childBuf, buf);

@@ -27984,9 +27983,6 @@ virDomainMemtuneFormat(virBufferPtr buf,
     }

     virXMLFormatElement(buf, "memtune", NULL, &childBuf);
-
-    ret = 0;
-    return ret;
 }


@@ -28489,9 +28485,7 @@ virDomainDefFormatInternalSetRootName(virDomainDefPtr def,
     if (virDomainDefFormatBlkiotune(buf, def) < 0)
         goto error;

-    if (virDomainMemtuneFormat(buf, &def->mem) < 0)
-        goto error;
-
+    virDomainMemtuneFormat(buf, &def->mem);
     virDomainMemorybackingFormat(buf, &def->mem);

     if (virDomainCpuDefFormat(buf, def) < 0)
-- 
2.23.0




More information about the libvir-list mailing list