[libvirt] [PATCH 2/2] qemu: use GUINT32_SWAP_LE_BE

Daniel P. Berrangé berrange at redhat.com
Wed Nov 13 11:54:56 UTC 2019


On Wed, Nov 13, 2019 at 12:44:57PM +0100, Peter Krempa wrote:
> On Wed, Nov 13, 2019 at 10:38:06 +0000, Daniel Berrange wrote:
> > On Wed, Nov 13, 2019 at 10:33:09AM +0100, Ján Tomko wrote:
> > > Use this GLib macro instead of bswap_32 from gnulib.
> > > 
> > > Signed-off-by: Ján Tomko <jtomko at redhat.com>
> > > ---
> > >  src/qemu/qemu_driver.c | 10 +++++-----
> > >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > Missing bootstrap.conf change to remove byteswap
> 
> We had a chat in person and we agreed to try to get rid of as much of
> the modules as possible by doing a "kill one gnulib module a day"
> initiative at the office.

FYI, most(all?) of the gnulib modules related to sockets/FDs will
need to be killed off in a single group, since they're all intertwined
to deal with the Windows HANDLE vs FD wrapping GNULIB does.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list