[libvirt] [PATCH v5 10/23] src: rewrite driver name checker in Python

Cole Robinson crobinso at redhat.com
Fri Nov 15 19:51:41 UTC 2019


On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> As part of an goal to eliminate Perl from libvirt build tools,
> rewrite the check-drivername.pl tool in Python.
> 
> This was mostly a straight conversion, manually going line-by-line
> to change the syntax from Perl to Python. Thus the overall structure
> of the file and approach is the same.
> 
> In testing though it was discovered the existing code was broken
> since it hadn't been updated after driver.h was split into many
> files. Since the old code is being thrown away, the fix was done
> as part of the rewrite rather than split into a separate commit.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  Makefile.am                 |   1 +
>  scripts/check-drivername.py | 114 ++++++++++++++++++++++++++++++++++++
>  src/Makefile.am             |  18 ++++--
>  src/check-drivername.pl     |  83 --------------------------
>  4 files changed, 129 insertions(+), 87 deletions(-)
>  create mode 100644 scripts/check-drivername.py
>  delete mode 100755 src/check-drivername.pl

There's a check-drivername.pl usage still in src/admin/Makefile.inc.am
after this

- Cole




More information about the libvir-list mailing list