[libvirt] [PATCH for-5.0 3/4] Remove the core bluetooth code

[Ján Tomko]

On Wed, Nov 20, 2019 at 10:10:13AM +0100, Thomas Huth wrote:
>It's been deprecated since QEMU v3.1. We've explicitly asked in the
>deprecation message that people should speak up on qemu-devel in case
>they are still actively using the bluetooth part of QEMU, but nobody
>ever replied that they are really still using it.
>
>I've tried it on my own to use this bluetooth subsystem for one of my
>guests, but I was also not able to get it running anymore: When I was
>trying to pass-through a real bluetooth device, either the guest did
>not see the device at all, or the guest crashed.
>
>Even worse for the emulated device: When running
>
> qemu-system-x86_64 -bt device:keyboard
>
>QEMU crashes once you hit a key.
>
>So it seems like the bluetooth stack is not only neglected, it is
>completely bitrotten, as far as I can tell. The only attention that
>this code got during the past years were some CVEs that have been
>spotted there. So this code is a burden for the developers, without
>any real benefit anymore. Time to remove it.
>
>Signed-off-by: Thomas Huth <thuth at redhat.com>
>---
> Makefile.objs        |    2 -
> bt-host.c            |  198 ----
> bt-vhci.c            |  167 ----
> configure            |   31 -
> hw/Kconfig           |    1 -
> hw/Makefile.objs     |    1 -
> hw/bt/Kconfig        |    2 -
> hw/bt/Makefile.objs  |    3 -
> hw/bt/core.c         |  143 ---
> hw/bt/hci-csr.c      |  512 ----------
> hw/bt/hci.c          | 2263 ------------------------------------------
> hw/bt/hid.c          |  553 -----------
> hw/bt/l2cap.c        | 1367 -------------------------
> hw/bt/sdp.c          |  989 ------------------
> include/hw/bt.h      | 2177 ----------------------------------------
> include/sysemu/bt.h  |   20 -
> qemu-deprecated.texi |    7 -
> qemu-options.hx      |   79 --
> vl.c                 |  136 ---
> 19 files changed, 8651 deletions(-)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191120/959890dd/attachment-0001.sig>