[libvirt] [PATCH v2 0/3] virt-aa-helper for shmem device

[Christian Ehrhardt]

On Thu, Nov 14, 2019 at 12:20 PM Christian Ehrhardt
<christian.ehrhardt at canonical.com> wrote:
>
> Cole was recently adding a few of the usual apparmor suspects to BZ 1761645
> and I was taking a look at the low hanging fruits of it today. It isn't
> perfect, but would resolve the reported issue - so I'd appreciate a
> review.
>
> Limitations:
> - One could break the path creating elements in qemuBuildShmemBackendMemProps
>   and qemuDomainPrepareShmemChardev into extra functions and then use those
>   from virt-aa-helper. But I haven't done so yet and unless it is strictly
>   required consider it too much for what we want/need to achieve here.
> - I haven't covered hotplug of shmem devices yet, it seems there is no
>   infrastructure for their labels yet and I wasn't sure how important
>   shmem-hotplug would even be to anyone.
>
> Updates in v2:
> - rebase latest master
> - drop checking shmems[i]
> - switch to use g_strdup_printf
> - added an extra patch removing checks like ctl->def->mems[i]
> - add reviewed-by tag

Thanks everyone for the further review and discussion.
Pushing with Ack/Review Tags after a rebuild/recheck


> Christian Ehrhardt (3):
>   virt-aa-helper: add rules for shmem devices
>   virt-aa-helper: testcase for shmem devices
>   virt-aa-helper: drop pointer checks in get_files
>
>  src/security/virt-aa-helper.c | 166 +++++++++++++++++++---------------
>  tests/virt-aa-helper-test     |  15 +++
>  2 files changed, 109 insertions(+), 72 deletions(-)
>
> --
> 2.24.0
>


--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd