[libvirt] [PATCH 2/3] scripts: check-aclrules: use in instead of find

Erik Skultety eskultet at redhat.com
Thu Nov 21 09:20:16 UTC 2019


On Thu, Nov 21, 2019 at 09:27:31AM +0100, Erik Skultety wrote:
> On Wed, Nov 20, 2019 at 07:32:45PM +0100, Ján Tomko wrote:
> > For checking whether a substring is present in a string,
> > using the pattern:
> >     "str" in string
> > is slightly faster than:
> >     string.find("str") != -1
> >
> > Use it to shave off 4 % of the runtime of this script that
> > processes quite a few long source files.
> >
>
> This is also the case in python FWIW...

Derp...clearly I didn't have my cup of coffee in the morning, since I thought
this was related to perl, sorry for the noise.

Erik

>
> > Signed-off-by: Ján Tomko <jtomko at redhat.com>
> > ---
>
> Reviewed-by: Erik Skultety <eskultet at redhat.com>
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list




More information about the libvir-list mailing list