[libvirt] [PATCH 02/21] virsh: Implement VIR_DOMAIN_JOB_DISK_TEMP_(USED|TOTAL) in cmdDomjobinfo
Eric Blake
eblake at redhat.com
Wed Nov 27 15:42:47 UTC 2019
On 11/26/19 3:39 PM, Peter Krempa wrote:
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
> tools/virsh-domain.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> index 325d748b49..ec9292a5c1 100644
> --- a/tools/virsh-domain.c
> +++ b/tools/virsh-domain.c
> @@ -6388,6 +6388,24 @@ cmdDomjobinfo(vshControl *ctl, const vshCmd *cmd)
> vshPrint(ctl, "%-17s %-13d\n", _("Auto converge throttle:"), ivalue);
> }
>
> + if ((rc = virTypedParamsGetULLong(params, nparams,
> + VIR_DOMAIN_JOB_DISK_TEMP_USED,
> + &value)) < 0) {
> + goto save_error;
> + } else if (rc) {
> + val = vshPrettyCapacity(value, &unit);
> + vshPrint(ctl, "%-17s %-.3lf %s\n", _("Temporary disk space use:"), val, unit);
Should we be using the table formatter, rather than formatting columns
ourselves? Particularly true since 'Temporary disk space use:' is
longer than 17 bytes, so our format string is insufficient.
But seems to be pre-existing, so not a showstopper for this patch.
Reviewed-by: Eric Blake <eblake at redhat.com>
> + }
> +
> + if ((rc = virTypedParamsGetULLong(params, nparams,
> + VIR_DOMAIN_JOB_DISK_TEMP_TOTAL,
> + &value)) < 0) {
> + goto save_error;
> + } else if (rc) {
> + val = vshPrettyCapacity(value, &unit);
> + vshPrint(ctl, "%-17s %-.3lf %s\n", _("Temporary disk space total:"), val, unit);
> + }
> +
> ret = true;
>
> cleanup:
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
More information about the libvir-list
mailing list