[libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

Philippe Mathieu-Daudé philmd at redhat.com
Wed Nov 27 22:35:30 UTC 2019


On 11/27/19 10:31 PM, Aleksandar Markovic wrote:
> On Wed, Nov 27, 2019 at 10:17 PM Philippe Mathieu-Daudé
> <philmd at redhat.com> wrote:
>>
>> Hi Aleksandar,
>>
>> On 11/27/19 7:47 PM, Aleksandar Markovic wrote:
>>> On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé
>>> <philmd at redhat.com> wrote:
>>>>
>>>> The r4k machine was introduced in 2005 (6af0bf9c7) and its last
>>>> logical change was in 2005 (9542611a6). After we can count 164
>>>> maintenance commits (QEMU API changes) with the exception of
>>>> 1 fix in 2015 (memory leak, commit 3ad9fd5a).
>>>>
>>>> This machine was introduced as a proof of concept to run a MIPS
>>>> CPU. 2 years later, the Malta machine was add (commit 5856de80)
>>>> modeling a real platform.
>>>>
>>
>> Since you queued this patch, do you mind adding Aurelien comment to the
>> patch description, as it appears important information:
>>
>> '''
>> The Linux kernel support for this machine has been dropped more
>> than 10 years ago in this commit:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=302922e5f6901eb6f29c58539631f71b3d9746b8
>> '''
>>
>> I was not sure when sending the patch, but as an improvement, we can
>> also remove Aurelien and Aleksandar Rikalo from the MAINTAINERS section.
>>
>> And I assume we can also add (which was explicit in your previous patch):
>> Acked-by: Aurelien Jarno <aurelien at aurel32.net>
>>
>> If you want I can resend this patch with all that amended.
>>
> 
> No need to resend, I'll fix the things while applying.

Thank you very much, very appreciated!





More information about the libvir-list mailing list