[libvirt] [PATCH v2 2/6] tools: introduce a data driven impl of virt-host-validate

Bjoern Walk bwalk at linux.ibm.com
Tue Oct 1 11:33:34 UTC 2019


Daniel P. Berrangé <berrange at redhat.com> [2019-09-27, 01:52PM +0100]:
> +package main
> +
> +import (
> +	"flag"
> +	"fmt"
> +	"github.com/spf13/pflag"

I don't like external dependencies like this at all. Not from a
administrative POV (there are likely a number of build environments,
including ours, that want to build libvirt offline) and not from a
security POV (this reminds me of the npm-debacles we see every now and
then).

> +	"io/ioutil"
> +	vl "libvirt.org/host-validate/pkg"
> +	"os"
> +	"path/filepath"
> +	"strings"
> +)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 902 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191001/3d3cf045/attachment-0001.sig>


More information about the libvir-list mailing list