[libvirt] [PATCH v2 0/5] build: take full ownership of syntax-check from gnulib
Michal Privoznik
mprivozn at redhat.com
Wed Oct 9 09:27:24 UTC 2019
On 10/8/19 5:48 PM, Daniel P. Berrangé wrote:
> Our syntax-check rule relies in various files imported during the gnulib
> bootstrap process. As we switch to meson & try to eliminate gnulib, we
> need to take ownership of syntax-check.
>
> This patch series follows the approach taken for libosinfo & other
> projects wrt syntax-check rules, but goes a step further and eliminates
> alot of baggage we don't care about & merges all logic into one file.
>
> Changed in v2:
>
> - Keep a top level GNUmakefile to preserve the hack
> that forced serialization of build targets
Yep, this helped.
>
> Daniel P. Berrangé (5):
> build: import gnulib's syntax-check make rules
syntax-check fails after this one, but I'm not sure it's worth trying to
fix it. I mean, of course it's failing, because maint.mk is not ignored
by syntax-check and yet contains examples of prohibited code patterns in
comments and such. Anyway, it's fixed in 2/5.
> build: move syntax-check code into build-aux directory
> build: remove all logic unrelated to syntax-check
> build: delete all syntax check rules we're skipping
> build: merge all syntax-check logic into one file
>
> .gitignore | 9 +-
> GNUmakefile | 74 ++
> Makefile.am | 7 +-
> bootstrap.conf | 4 -
> cfg.mk => build-aux/syntax-check.mk | 1122 +++++++++++++++++++++++++--
> build-aux/useless-if-before-free | 226 ++++++
> build-aux/vc-list-files | 113 +++
> configure.ac | 6 +
> 8 files changed, 1482 insertions(+), 79 deletions(-)
> create mode 100644 GNUmakefile
> rename cfg.mk => build-aux/syntax-check.mk (53%)
> create mode 100755 build-aux/useless-if-before-free
> create mode 100755 build-aux/vc-list-files
>
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>
Michal
More information about the libvir-list
mailing list