[libvirt] [PATCH 1/4] qemu: validate bochs-display capability

[Jonathon Jongsma]

ping series

On Fri, 2019-09-13 at 16:20 -0500, Jonathon Jongsma wrote:
> When the bochs display type was added, the capability was never
> checked.
> Add that check in the same place as the other video device capability
> checks.
> 
> Signed-off-by: Jonathon Jongsma <jjongsma at redhat.com>
> ---
>  src/qemu/qemu_process.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index 955ba4de4c..b93af966e2 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -5278,7 +5278,9 @@ qemuProcessStartValidateVideo(virDomainObjPtr
> vm,
>               !virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_GPU))
> ||
>              (video->type == VIR_DOMAIN_VIDEO_TYPE_VIRTIO &&
>               video->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW
> &&
> -             !virQEMUCapsGet(qemuCaps,
> QEMU_CAPS_DEVICE_VIRTIO_GPU_CCW))) {
> +             !virQEMUCapsGet(qemuCaps,
> QEMU_CAPS_DEVICE_VIRTIO_GPU_CCW)) ||
> +            (video->type == VIR_DOMAIN_VIDEO_TYPE_BOCHS &&
> +             !virQEMUCapsGet(qemuCaps,
> QEMU_CAPS_DEVICE_BOCHS_DISPLAY))) {
>              virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>                             _("this QEMU does not support '%s' video
> device"),
>                             virDomainVideoTypeToString(video->type));