[libvirt] [PATCH] m4: Improve portability for non-bash shells
Andrea Bolognani
abologna at redhat.com
Tue Oct 22 09:43:06 UTC 2019
On Sat, 2019-10-19 at 11:46 +0000, Maya Rashish wrote:
> = and == are both operators to test for string equality in bash,
> but only = is required by POSIX.
>
> Signed-off-by: Maya Rashish <coypu at sdf.org>
> ---
> m4/virt-nls.m4 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Welp, I'm surprised nobody noticed until now: the code in question
has been merged more than a year ago.
Anyway, your fix is correct, so
Reviewed-by: Andrea Bolognani <abologna at redhat.com>
and pushed.
Congratulation on your first libvirt contribution! :)
--
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list
mailing list