[libvirt] [jenkins-ci PATCH] libvirt-ocaml: run 'make check-manifest' as build step

Andrea Bolognani abologna at redhat.com
Tue Sep 3 09:07:36 UTC 2019


On Tue, 2019-09-03 at 10:55 +0200, Pino Toscano wrote:
> This ensures that the MANIFEST file is up-to-date, and thus dist will
> (hopefully) work.
> 
> Signed-off-by: Pino Toscano <ptoscano at redhat.com>
> ---
>  guests/playbooks/build/projects/libvirt-ocaml.yml | 1 +
>  jenkins/projects/libvirt-ocaml.yaml               | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/guests/playbooks/build/projects/libvirt-ocaml.yml b/guests/playbooks/build/projects/libvirt-ocaml.yml
> index 7a2e216..d293738 100644
> --- a/guests/playbooks/build/projects/libvirt-ocaml.yml
> +++ b/guests/playbooks/build/projects/libvirt-ocaml.yml
> @@ -25,3 +25,4 @@
>        ./configure --prefix=$VIRT_PREFIX
>        $MAKE
>        $MAKE opt
> +      $MAKE check-manifest

Wouldn't it make sense to have a separate libvirt-ocaml-check job for
this? Also, does libvirt-ocaml have a test suite we could run as part
of that job?

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list