[libvirt] [PATCH 4/4] virt-result.m4: Colourize summary printings

[Daniel P. Berrangé]

On Mon, Sep 09, 2019 at 09:49:42AM +0200, Michal Privoznik wrote:
> The LIBVIRT_RESULT function takes two or three arguments. The
> first one is the name of the result (aka CHECK_NAME). It is
> printed before the colon character. The rest of the arguments is
> printed after the character. To produce colourized output a
> couple of changes needs to be made.
> 
> Firstly, we need to print the CHECK_NAME using "echo -n" so that
> the new line is not appended at the end of the message. To
> achieve this, AS_MESSAGE_N function is introduced. It's a
> verbatim copy of AS_MESSAGE (which is just another alias to
> AC_MSG_NOTICE) except it doesn't put '\n' at the EOL.
> 
> The alias is defined at /usr/share/autoconf-*/autoconf/general.m4
> and the AS_MESSAGE is then defined at
> /usr/share/autoconf-2.69/m4sugar/m4sh.m4.
> 
> Secondly, the rest of the arguments are printed colourized and to
> achieve that and also keep printing them into the log file the
> _AS_ECHO and COLORIZE_RESULT functions need to be called.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  m4/virt-result.m4 | 21 ++++++++++++++++++---
>  1 file changed, 18 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|