[libvirt] [PATCH 1/5] virsh: Allow using VIR_AUTOPTR for releasing virDomainPtr in virsh

Daniel Henrique Barboza danielhb413 at gmail.com
Tue Sep 17 14:09:48 UTC 2019



On 9/16/19 9:45 AM, Peter Krempa wrote:
> I opted to alias the 'virDomainType' to 'virshDomain' so that it's
> obvious in all cases that this is a virsh-only construct. This is also
> somewhat consistent with virsh's use of 'virshDomainFree' wrapper for
> the freeing function which actually accepts NULL.
>
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>

>   tools/virsh-util.h | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/tools/virsh-util.h b/tools/virsh-util.h
> index 9005aa9d36..7fdd39dd12 100644
> --- a/tools/virsh-util.h
> +++ b/tools/virsh-util.h
> @@ -39,8 +39,11 @@ virshCommandOptDomain(vshControl *ctl,
>                         const vshCmd *cmd,
>                         const char **name);
>
> +typedef virDomain virshDomain;
> +
>   void
>   virshDomainFree(virDomainPtr dom);
> +VIR_DEFINE_AUTOPTR_FUNC(virshDomain, virshDomainFree);
>
>   void
>   virshDomainCheckpointFree(virDomainCheckpointPtr chk);




More information about the libvir-list mailing list