[libvirt] [PATCH 5/9] qemu: block: Replace snapshot transaction action generator

Eric Blake eblake at redhat.com
Thu Sep 26 22:48:40 UTC 2019


On 9/26/19 11:05 AM, Peter Krempa wrote:
> Use the new generator residing in the monitor code rather than directly
> using qemuMonitorJSONTransactionAdd.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_block.c | 21 ++++-----------------
>   1 file changed, 4 insertions(+), 17 deletions(-)
> 

You could almost squash this in with introducing the monitor functions 
(making it easier to see that the added code and the removed code 
produce the same JSON).  But separate is fine, too.

Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list