[PATCH 2/2] backup: Allow 'encryption' of backups and scratch images

[Erik Skultety]

On Tue, Apr 14, 2020 at 11:22:44AM +0200, Peter Krempa wrote:
> Add the appropriate entries into the schema to allow encryption of the
> backup or scratch image. Since we use blockdev internals for everything
> no changes to the code are actually necessary.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1811906
>
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  docs/formatbackup.html.in                     | 14 +++-
>  docs/schemas/domainbackup.rng                 | 65 +++++++++++++++----
>  .../backup-pull-encrypted.xml                 | 30 +++++++++
>  .../backup-push-encrypted.xml                 | 29 +++++++++
>  .../backup-pull-encrypted.xml                 | 30 +++++++++
>  .../backup-push-encrypted.xml                 | 29 +++++++++
>  tests/genericxml2xmltest.c                    |  3 +
>  7 files changed, 185 insertions(+), 15 deletions(-)
>  create mode 100644 tests/domainbackupxml2xmlin/backup-pull-encrypted.xml
>  create mode 100644 tests/domainbackupxml2xmlin/backup-push-encrypted.xml
>  create mode 100644 tests/domainbackupxml2xmlout/backup-pull-encrypted.xml
>  create mode 100644 tests/domainbackupxml2xmlout/backup-push-encrypted.xml
>
> diff --git a/docs/formatbackup.html.in b/docs/formatbackup.html.in
> index 87744bac98..9e69d8f7d3 100644
> --- a/docs/formatbackup.html.in
> +++ b/docs/formatbackup.html.in
> @@ -101,7 +101,7 @@
>                  <code>block</code>.
>                  Similar to a disk declaration for a domain, the choice of type
>                  controls what additional sub-elements are needed to describe
> -                the destination.
> +                the destination.</dd>

^This hunk needs to go into the previous commit, otherwise the previous patch
breaks the build.

With that fixed (to both patches):
Reviewed-by: Erik Skultety <eskultet at redhat.com>