[PATCH 17/36] datatypes: convert virNWFilter to GObject
Jonathon Jongsma
jjongsma at redhat.com
Wed Apr 8 21:12:04 UTC 2020
On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote:
> @@ -503,14 +503,13 @@ virNWFilterGetXMLDesc(virNWFilterPtr nwfilter,
> unsigned int flags)
> int
> virNWFilterRef(virNWFilterPtr nwfilter)
> {
> - VIR_DEBUG("nwfilter=%p refs=%d", nwfilter,
> - nwfilter ? nwfilter->parent.u.s.refs : 0);
> + VIR_DEBUG("nwfilter=%p", nwfilter);
I wonder about this change. If it doesn't include the ref count in the
debug message, is it actually still useful to anyone? I've never used
it, so I don't know. If we want to keep it, we could of course access
the GObject ref_count member variable.
>
> virResetLastError();
>
> virCheckNWFilterReturn(nwfilter, -1);
>
> - virObjectRef(nwfilter);
> + g_object_ref(nwfilter);
> return 0;
> }
>
More information about the libvir-list
mailing list